Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the JWST pipeline to accommodate the new likelihood algorithm in ramp fitting #8560

Closed
stscijgbot-jp opened this issue Jun 13, 2024 · 2 comments

Comments

@stscijgbot-jp
Copy link
Collaborator

Issue JP-3658 was created on JIRA by Kenneth MacDonald:

A new algorithm has been added to the ramp fitting module in STCAL that the JWST pipeline can select (JP-3576).

 

The likelihood algorithm does its own jump detection during the ramp fitting processing, so the existing separate jump detection algorithm done in the pipeline should be skipped if the likelihood algorithm is selected for ramp fitting.  

 

Additionally, if the likelihood algorithm is selected the NGROUPS of the data should be checked.  If NGROUPS is 3 or less, then the OLS ramp fitting algorithm should be used and the normal pipeline jump detection algorithm should be run.  The minimum ramp size for the likelihood to run correctly is 4 groups per ramp.

@stscijgbot-jp
Copy link
Collaborator Author

Comment by Melanie Clarke on JIRA:

Changes implemented in #8631

It was decided in development and testing to not turn off jump by default, since the flags might be needed for the clean_flicker_noise step.  The changes here are just to make the LIKELY algorithm available, and default to OLS_C if NGROUPS < 4.

@stscijgbot-jp
Copy link
Collaborator Author

Comment by David Law on JIRA:

Confirmed that the new step is working; further testing will take place in dedicated ticket https://jira.stsci.edu/browse/JP-3765

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant