Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump detection with multiple 2-group integrations #6729

Closed
stscijgbot-jp opened this issue Feb 14, 2022 · 9 comments
Closed

Jump detection with multiple 2-group integrations #6729

stscijgbot-jp opened this issue Feb 14, 2022 · 9 comments

Comments

@stscijgbot-jp
Copy link
Collaborator

Issue JP-2517 was created on JIRA by Anton Koekemoer:

This proposed enhancement to the baseline algorithm follows on from an earlier ticket (JP-1885) which covered 3- and 4-group cases. That was since implemented, but an additional enhancement is the special case for multiple 2-group integrations, where the proposal is to process all the differences in the exposure at once. This would allow jumps to be found in all integrations with at least 2 groups, and would be especially beneficial for TSO observations.
 

 

@stscijgbot-jp
Copy link
Collaborator Author

Comment by Howard Bushouse on JIRA:

Michael Regan does the recent implementation of the only_use_ints param (and perhaps others) in the jump step address this issue in anyway, or is it completely different?

@stscijgbot-jp
Copy link
Collaborator Author

Comment by Anton Koekemoer on JIRA:

Michael Regan can this issue be closed (if it's addressed in the way Howard Bushouse describes above) or is further work needed to resolve this ticket?

@stscijgbot-jp
Copy link
Collaborator Author

Comment by Anton Koekemoer on JIRA:

closing this ticket, as Michael Regan confirmed during JWST Cal WG Meeting 2023-11-07 that this issue is now resolved.

@stscijgbot-jp
Copy link
Collaborator Author

Comment by Anton Koekemoer on JIRA:

closing this ticket, as Michael Regan confirmed during JWST Cal WG Meeting 2023-11-07 that this issue is now resolved.

@stscijgbot-jp
Copy link
Collaborator Author

Comment by Howard Bushouse on JIRA:

Michael Regan For the record, is there a particular PR that can be referenced as solving this?

@stscijgbot-jp stscijgbot-jp reopened this Nov 9, 2023
@stscijgbot-jp
Copy link
Collaborator Author

Comment by Anton Koekemoer on JIRA:

Setting this back to 'in progress' until we hear from Michael Regan about the above.

@stscijgbot-jp
Copy link
Collaborator Author

Comment by Howard Bushouse on JIRA:

Michael Regan Still need to know which PR is responsible for resolving this ticket. Right now the state of the ticket is entirely confusing: status is "In Progress", but "Resolution" is "Done", with no Fix Version specified.

@stscijgbot-jp
Copy link
Collaborator Author

Comment by Michael Regan on JIRA:

Howard Bushouse It looks like it is #⁠174 in STCAL. The default parameter requires at least 101 integration for it to switch to sigma clip.

@stscijgbot-jp
Copy link
Collaborator Author

Comment by Howard Bushouse on JIRA:

Fixed by spacetelescope/stcal#174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants