Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in treatment of pixel_bounds #496

Open
astrofrog opened this issue May 9, 2024 · 0 comments · May be fixed by #498
Open

Bug in treatment of pixel_bounds #496

astrofrog opened this issue May 9, 2024 · 0 comments · May be fixed by #498

Comments

@astrofrog
Copy link

astrofrog commented May 9, 2024 •
edited
Loading

Currently if I create a GWCS using the example at the front of the docs:

In [1]: import numpy as np
   ...: from astropy.modeling import models
   ...: from astropy.coordinates import ICRS, SkyCoord
   ...: from astropy import units as u
   ...: from gwcs import wcs
   ...: from gwcs import coordinate_frames as cf
   ...: 
   ...: pixelshift = models.Shift(-500) & models.Shift(-500)
   ...: pixelscale = models.Scale(0.1 / 3600.0) & models.Scale(0.1 / 3600.0)  # 0.1 arcsec/pixel
   ...: tangent_projection = models.Pix2Sky_TAN()
   ...: celestial_rotation = models.RotateNative2Celestial(30.0, 45.0, 180.0)
   ...: 
   ...: det2sky = pixelshift | pixelscale | tangent_projection | celestial_rotation
   ...: 
   ...: detector_frame = cf.Frame2D(name="detector", axes_names=("x", "y"), unit=(u.pix, u.pix))
   ...: 
   ...: sky_frame = cf.CelestialFrame(reference_frame=ICRS(), name="icrs", unit=(u.deg, u.deg))
   ...: 
   ...: wcsobj = wcs.WCS([(detector_frame, det2sky), (sky_frame, None)])
   ...: 
   ...: wcsobj.bounding_box = ((0, 10), (0, 20))

the pixel_bounds are defined, which is good:

In [3]: wcsobj.pixel_bounds
Out[3]: ((0, 10), (0, 20))

However, these pixel bounds currently only apply to pixel to world transformations:

In [4]: print(wcsobj.pixel_to_world(10, 10))
   ...: 
<SkyCoord (ICRS): (ra, dec) in deg
    (29.98075555, 44.98638727)>

In [5]: print(wcsobj.pixel_to_world(30, 10))
<SkyCoord (ICRS): (ra, dec) in deg
    (nan, nan)>

and not world to pixel transformations:

In [6]: wcsobj.world_to_pixel(SkyCoord(30, 50, unit="deg"))
Out[6]: [500.0000000002625, 180958.32230992112]

However, this should return [nan, nan].
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Respect the bounding_box in inverse transforms nden/gwcs
1 participant
@astrofrog