Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: icondiff show incorrect diffs #25

Open
Dimach opened this issue Aug 16, 2023 · 4 comments
Open

Bug: icondiff show incorrect diffs #25

Dimach opened this issue Aug 16, 2023 · 4 comments

Comments

@Dimach
Copy link

Dimach commented Aug 16, 2023

Here it show almost entire file changed, and icons shuffled randomly ss220-space/Paradise#3342
Here it shows chnages in nianflag_fire (flags_lefthand.dmi, flags_righthand.dmi) when there was no changes, also it show wrong animation ss220-space/Paradise#3354
When DMI files not contains animation behavior looks correct

@GoldenAlpharex
Copy link

I have another instance of this:
https://github.com/Skyrat-SS13/Skyrat-tg/runs/16449958042

It seems as though it's not parsing the amount of frames properly, and is shifting some frames around on accident, when there's some mix between animations and non-animations within the same file.

@volas
Copy link

volas commented Dec 1, 2023

@ZeWaka
Copy link
Member

ZeWaka commented Dec 16, 2023

@volas
Copy link

volas commented Dec 16, 2023

I think it's fixed in #30

fixes reading the wrong frame number from the wrong number of delays

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants