Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TV Shows #100

Open
wtimme opened this issue Jul 14, 2019 · 1 comment
Open

Add support for TV Shows #100

wtimme opened this issue Jul 14, 2019 · 1 comment

Comments

@wtimme
Copy link
Contributor

wtimme commented Jul 14, 2019

Is your feature request related to a problem? Please describe.
The app is great so far, thanks a lot! It helps me get rid of a (not-very pretty) list I kept in Notes.app.
Another list that I have is the one with the TV shows I plan on watching. I would like to be able to add them to the app.

Describe the solution you'd like
I want to be able to search for TV Shows and track them, similar to movies. When I tap the "+" button, I should be able to search for TV Shows.
Visually, the app could present a segmented control with the options "Movie" and "TV Show".
The information displayed for TV Shows could initially be the same as for movies.

Documentation

@wtimme
Copy link
Contributor Author

wtimme commented Jul 14, 2019

Looking at the code, I feel like this requires a little bit of planning.

The Movie model has some properties that it shares with a TV Show, namely

  • id
  • title (a TV Shows has a name)
  • voteAverage
  • voteCount
  • posterPath
  • overview
  • releaseDate(a TV Shows has a first_air_date)

How can we avoid redundancy? I feel like just copy-and-pasting the Movie model is not the way to go here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants