Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a webform to create PRs #3

Open
dns2utf8 opened this issue Jan 19, 2017 · 7 comments
Open

Create a webform to create PRs #3

dns2utf8 opened this issue Jan 19, 2017 · 7 comments
Labels

Comments

@dns2utf8
Copy link
Member

The website would present a form for new entries.
Once the new entry is validated and checked against duplicates the users request will be translated into a pull request against the current master of the database repo.

@dbrgn
Copy link
Member

dbrgn commented Jan 19, 2017

We could also offer a dropdown of existing entries to be updated.

@romedius
Copy link

concerning the updates:
there is an issue_mail field in the spaceapi 1.13 specification.
We could mail a validation token to the given adress to allow updating the URL changes.

@dbrgn
Copy link
Member

dbrgn commented Jan 22, 2017

Yes, but what if someone entered a wrong e-mail once and cannot update it anymore?

And if we simply believe someone saying "I cannot access the original e-mail anymore", then what additional security does that validation token bring us?

I think having no authentication but peer review on Github is probably the more pragmatic approach.

@romedius
Copy link

@dbrgn the original email adress is in the json file provided from your server. So you should be able to change it. As long as you own the Domain, it is possible.
It would be an extra solution. For the tiny dataset we curate now, peer reviewed Pull requests are enouth, you are right :)

@dns2utf8
Copy link
Member Author

Something like this?

  1. User submits URL
  2. Server fetches the URL
  3. Server sends an eMail to the listed address
  4. User clicks the token received by eMail
  5. Server creates PR with entry

@dbrgn
Copy link
Member

dbrgn commented Jan 24, 2017

👍

I'd suggest implementing the form with direct PR creation first though, and only adding verification once we start having problems with that approach.

@rorist
Copy link

rorist commented Jan 28, 2017

+1 for the webform and direct PR, anybody in a hackerspace should be able to create and update the url, not only the one controlling the email/server. People will probably loss acces to the email, then we'd need a mechanism to re-authenticate the space url, which seems complicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants