Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difference in behaviour on Windows vs Linux - Does not close launcher after exiting #175

Open
amylizzle opened this issue Aug 12, 2024 · 2 comments

Comments

@amylizzle
Copy link

On Linux, launching the launcher with a URI to connect to a server closes the launcher when the client exits. On Windows the launcher is left running.

For my usecase (OD vscode extension) it would be ideal if they both closed when the client exits.

@deathride58
Copy link
Member

deathride58 commented Aug 12, 2024

The launcher staying open is explicitly required for redial (the ability for the client to shut down and reconnect to a server, for updates and the like); the launcher closing on Linux when connecting with a URI seems like a bug (especially given that nowhere in the URI handler is the launcher deliberately closing itself as far as we can see).

What sort of flow are you looking for here that'd require the launcher to close itself?

@amylizzle
Copy link
Author

oh then that seems like a bug on the Linux side. Essentially OpenDream has a vscode extension that downloads and runs the opendream and ss14 launcher binaries, with the goal of debugging DM code. What I want to happen (and what happens on linux) is:

  1. The OD compiler runs
  2. The OD Robust.Server binary runs with the compiled DM
  3. The launcher starts with a local URI (ie, ss14://localhost:1212)
  4. The launcher does all the dependency stuff and starts the client
  5. After the client finishes running (user closes it or something), the launcher also stops running

On Windows, the launcher continues to run necessitating closing it manually to end the debugging session in vscode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants