Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assets fail to load: Port must be 8081 #9

Open
german-e-mas opened this issue Nov 8, 2022 · 2 comments
Open

Assets fail to load: Port must be 8081 #9

german-e-mas opened this issue Nov 8, 2022 · 2 comments

Comments

@german-e-mas
Copy link
Contributor

CSS and assets are requested from localhost:8081 regardless of the port used by running ./develop_server.sh start [port], which causes the page to load without them.

Raising awareness of this issue. We should double check how the develop_server.sh script is working alongside Pelican.

Running the website with ./develop_server.sh start 8081 works as intended.

@german-e-mas
Copy link
Contributor Author

german-e-mas commented Nov 8, 2022

This is related to the SITEURL being http://localhost:8081 in the pelicanconfig.py file.

@german-e-mas
Copy link
Contributor Author

The settings for development hardcode the SITEURL to http://localhost:8081. Setting a different port won't really work, as we declare it already in the SITEURL.

The settings for production have the proper SITEURL configured at https://space.ros.org.

Having said that, the problem here lies in the develop_server file. Latest Pelican builds use an underlying Makefile in order make some pelican commands more accessible. That approach would be much simpler.


Tasks:

  • Use a Makefile instead of the develop_server.sh file.
  • Update Readme (or devnotes, if we want more indepth comments) with how to use that Makefile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant