What's the point of this call to source?

[ivanperez-keera]

I just noticed that we are all over the place calling bash -c 'source <path>' before we execute ros-related commands. To me, this makes sense under the assumption that the adjustments made by those invocations do not persist across docker RUNs.

But then I noticed the same at the very end of a RUN:

docker/space_robots/Dockerfile

Line 78 in 76cd412

RUN vcs import src < /tmp/demo_manual_pkgs.repos && /bin/bash -c 'source "${SPACEROS_DIR}/install/setup.bash"'

What's the point of doing that?

If the effects of calling source persist across RUNs, then should these be simplified throughout the file? Note that just removing duplication is not enough of a reason to factorize those; there are circumstances under which you want to spell it out twice.

If the effects of calling source do not persist across RUNs, then we should just remove that last bit from the line above.

[ivanperez-keera]

I'm opening this as a question first because it's likely that I'm just misunderstanding something. Please do me an educate 😄

[Bckempa]

This could be combined with #102 / #108 into a dockerfile cleanup issue once space-ros/space-ros#114 is resolved

[EzraBrooks]

If the effects of calling source do not persist across RUNs, then we should just remove that last bit from the line above.

This is the case. Each RUN directive is executed in a separate sub-shell for idempotence/reproducibility reasons.