From 36b67e07bcb9558715f560e0319b4ddd9f75a4a9 Mon Sep 17 00:00:00 2001 From: Chomp Date: Fri, 21 Feb 2025 23:07:16 +0000 Subject: [PATCH] Fixed incorrect pack offer prices --- project/src/generators/RagfairOfferGenerator.ts | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/project/src/generators/RagfairOfferGenerator.ts b/project/src/generators/RagfairOfferGenerator.ts index 7da2e68c2..37dd51480 100644 --- a/project/src/generators/RagfairOfferGenerator.ts +++ b/project/src/generators/RagfairOfferGenerator.ts @@ -142,7 +142,6 @@ export class RagfairOfferGenerator { // Clone to avoid modifying original array const itemsClone = this.cloner.clone(items); - const itemStackCount = itemsClone[0].upd?.StackObjectsCount ?? 1; // Hydrate ammo boxes with cartridges + ensure only 1 item is present (ammo box) // On offer refresh dont re-add cartridges to ammo box that already has cartridges @@ -151,7 +150,7 @@ export class RagfairOfferGenerator { } const roubleListingPrice = Math.round(this.convertOfferRequirementsIntoRoubles(offerRequirements)); - const singleItemListingPrice = isPackOffer ? roubleListingPrice / itemStackCount : roubleListingPrice; + const singleItemListingPrice = isPackOffer ? roubleListingPrice / quantity : roubleListingPrice; const offer: IRagfairOffer = { _id: this.hashUtil.generate(), @@ -476,7 +475,7 @@ export class RagfairOfferGenerator { itemToSellDetails: ITemplateItem, ): Promise { // Set stack size to random value - var desiredStackSize = this.ragfairServerHelper.calculateDynamicStackCount(itemWithChildren[0]._tpl, isPreset); + let desiredStackSize = this.ragfairServerHelper.calculateDynamicStackCount(itemWithChildren[0]._tpl, isPreset); // Reset stack count to 1 from whatever it was prior itemWithChildren[0].upd.StackObjectsCount = 1; @@ -510,14 +509,13 @@ export class RagfairOfferGenerator { let barterScheme: IBarterScheme[]; if (isPackOffer) { // Set pack size - const stackSize = this.randomUtil.getInt( + desiredStackSize = this.randomUtil.getInt( this.ragfairConfig.dynamic.pack.itemCountMin, this.ragfairConfig.dynamic.pack.itemCountMax, ); - itemWithChildren[0].upd.StackObjectsCount = stackSize; // Don't randomise pack items - barterScheme = this.createCurrencyBarterScheme(itemWithChildren, isPackOffer, stackSize); + barterScheme = this.createCurrencyBarterScheme(itemWithChildren, isPackOffer, desiredStackSize); } else if (isBarterOffer) { // Apply randomised properties this.randomiseOfferItemUpdProperties(sellerId, itemWithChildren, itemToSellDetails);