-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sozuctl: deserialize the configuration correctly during upgrades #364
Comments
For more context, I had troubles when upgrading sozu after the proxy protocol PR was merged. To reproduce:
The master should panic:
It shouldn't have happened and |
this error is linked to the |
For a bit more context, this is linked to #104 |
so, I took a closer look. When some fields are removed, they will be silently ignored on upgrade. When some fields are added, deserialization of the upgrade data will fail in the new master process (because it does not see a field it expects). I expect another upgrade issue between 0.5 and master, since we renamed instances to backends. But for the rest of the configuration, default fields should work properly |
The first example of using default values for deserialization was done in b07fd1f. I can confirm it works |
Before we start to upgrade the running sozu, sozuctl should check if the configuration file has the right format / options. It should use what has been done in #363
The text was updated successfully, but these errors were encountered: