Literal string 'null' stored in changed_field

[jameskirsop]

I'm seeing a literal string of 'null' being stored in the database against some Update events.

If there aren't any changed fields one of the following should be occurring instead:

1. The event isn't logged as an 'Update' at all - as nothing has changed on the object
2. The changed_fields column should be left empty - null - instead of 'null'.

This bug makes it tedious to .filter() for actual changes to a given object.

[guy881]

I would opt for number 1. @soynatan @jheld, what do you think about this?

[gghildyal]

Number 1 is addressed now with #106.

[jameskirsop]

Would appreciate if @gghildyal's PR could be merged into master!

[jheld]

I'm happy with option 1, as well. Likely to merge #106 shortly.

If option 1 has any process issues for certain projects, then we can enable a new setting which allows doing the update and saving it as NULL instead. But for now, simpler seems better.

[jheld]

merged and released to PyPI as 1.2.2b1.

there might be a couple other changes in this release so I'm not marking as release candidate yet. Once we've frozen 1.2.2's changeset, we'll do (probably just 1) release candidate, and then after small testing, official release.

[jameskirsop]

Thanks @jheld!

[alsichel]

Still having this issue. I'm on version 1.3.3a3