Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed_fields are not passed to the callback. #111

Closed
gghildyal opened this issue Oct 25, 2019 · 3 comments
Closed

changed_fields are not passed to the callback. #111

gghildyal opened this issue Oct 25, 2019 · 3 comments

Comments

@gghildyal
Copy link

I want to make a decision on whether to audit log or not based on whether something changed. Like omit anything that's auto updated by the model (models inheriting from TimeStampedModel for instance). The code calculates the changed_fields for updates but doesn't pass it to the callback.
@gghildyal
Copy link
Author

I have created a PR for this - #112

@gghildyal
Copy link
Author

This will be addressed by #106

@jheld
Copy link
Collaborator

jheld commented Feb 13, 2020

PR #106 has been merged and released. Open to discussing in case we want to change the flow a bit, but closing for now.

@jheld jheld closed this as completed Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jheld @gghildyal