Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environments in URLs #281

Closed
tmberthold opened this issue Aug 20, 2024 · 1 comment
Closed

Environments in URLs #281

tmberthold opened this issue Aug 20, 2024 · 1 comment
Labels
kind/bug Something isn't working. The software does not behave as expected or specified. scope/mds related to MDS
Milestone

Comments

@tmberthold
Copy link
Contributor

Description - What happened? *

Hardcoded environment URL found in AuthPortal UI: [...]/catalog?environmentId=test

Expected Behavior *

Hardcoded environment URL should be removed

Observed Behavior *

environment mentioned in URL

Steps to Reproduce

Steps to reproduce the behavior:
- Log in to the MDS Portal.
- Navigate to "Data Catalogue page"

Context Information

No response

Relevant log output

No response

Screenshots

No response

@tmberthold tmberthold added kind/bug Something isn't working. The software does not behave as expected or specified. scope/mds related to MDS labels Aug 20, 2024
@tmberthold tmberthold added this to the MDS 2.2 milestone Aug 20, 2024
@AbdullahMuk
Copy link
Collaborator

Bug will not be resolved based on below context.

@tmberthold please communicate to MDS Project process accordingly. /cc @jkbquabeck

Thank you for bringing this to our attention. I understand that there may be some confusion regarding the environment IDs in the URL. Let me clarify:

The environment IDs in the URL are not “hardcoded” as it might seem. They are dynamically generated and essential for the functionality of our system. This design decision was made based on the specific requirements of the MDS. Also, the AP v4.0.0 release does introduce the use of environment IDs in the URL.

The feature request required permalinks for each data offer, which necessitates the use of these environment IDs. Additionally, the feature request required wanted a unique link to the data catalog for each environment. This also requires the use of environment IDs.

This design choice was made with careful consideration and is crucial for the system to function as intended.

@AbdullahMuk AbdullahMuk closed this as not planned Won't fix, can't repro, duplicate, stale Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working. The software does not behave as expected or specified. scope/mds related to MDS
Projects
None yet
Development

No branches or pull requests

2 participants