Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Broker] Speedup Broker Server Tests #376

Closed
3 tasks
richardtreier opened this issue Jul 13, 2023 · 4 comments
Closed
3 tasks

[Broker] Speedup Broker Server Tests #376

richardtreier opened this issue Jul 13, 2023 · 4 comments
Labels
component/ap Impacts Authority Portal or requires development on Authority Portal. task/refactor Code needs refactoring

Comments

@richardtreier
Copy link
Collaborator

richardtreier commented Jul 13, 2023 •
edited
Loading

Feature Request

Description

  • Speedup Broker Server Tests by re-using DB. Right now we have JUnit Extension that launches a DB for each test, maybe re-uses it, but we now want to explicitly have only one global Test
  • Ensure that tests that dirty the DB (idk by not using test transactions) rebuild the DB after their test execution, by calling FlywayUtils.cleanAndMigrate(TEST_DATABASE).
  • Currently the tests are always executing flyway migrations on the "test edc startup". Make the flyway migration deactivatable by config, so the tests can skip it and set up the db globally once with FlywayUtils.cleanAndMigrate(TEST_DATABASE).
@richardtreier richardtreier added task/refactor Code needs refactoring scope/mds related to MDS labels Jul 13, 2023
@SaadEGI
Copy link
Contributor

SaadEGI commented Jul 27, 2023

Both Implementation take ~20 seconds, is it worth timewise it to use the same instance for the Tests?

@SaadEGI
Copy link
Contributor

SaadEGI commented Jul 27, 2023

grafik

@AbdullahMuk AbdullahMuk added the clean-backlog requires backlog cleaning label May 2, 2024
@tmberthold tmberthold changed the title Speedup Broker Server Tests [Broker] Speedup Broker Server Tests Jun 4, 2024
@tmberthold tmberthold transferred this issue from sovity/edc-broker-server-extension Jun 4, 2024
@SebastianOpriel
Copy link
Member

@richardtreier still a relevant issue?

@AbdullahMuk AbdullahMuk removed the scope/mds related to MDS label Nov 20, 2024
@AbdullahMuk AbdullahMuk transferred this issue from sovity/edc-ce Nov 20, 2024
@AbdullahMuk AbdullahMuk added component/ap Impacts Authority Portal or requires development on Authority Portal. and removed clean-backlog requires backlog cleaning labels Nov 20, 2024
@richardtreier
Copy link
Collaborator Author

closed, out of date, irrelevant now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/ap Impacts Authority Portal or requires development on Authority Portal. task/refactor Code needs refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@SebastianOpriel @SaadEGI @richardtreier @AbdullahMuk