From 70445a054da54d37ef2f54013cf8c18b115f408e Mon Sep 17 00:00:00 2001 From: Ilia Orlov <66363651+illfixit@users.noreply.github.com> Date: Wed, 13 Mar 2024 09:45:29 +0100 Subject: [PATCH] fix: favicon, page titles (#61) --- CHANGELOG.md | 1 + .../breadcrumb/breadcrumb.component.ts | 9 ++++++++- authority-portal-frontend/src/favicon.ico | Bin 948 -> 0 bytes authority-portal-frontend/src/index.html | 2 +- 4 files changed, 10 insertions(+), 2 deletions(-) delete mode 100644 authority-portal-frontend/src/favicon.ico diff --git a/CHANGELOG.md b/CHANGELOG.md index 4306cbb32..aa5f604d0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -29,6 +29,7 @@ please see [changelog_updates.md](docs/dev/changelog_updates.md). - Fix provisioning CaaS breaking dashboard ([#27](https://github.com/sovity/authority-portal/issues/27)) - Fixed the text being cut off in the connector self-hosting instructions ([#35](https://github.com/sovity/authority-portal/issues/35)) - Fixed inconsistent placeholder values for privacy policy and legal notice links ([#41](https://github.com/sovity/authority-portal/issues/41)) +- Fixed favicon and page titles being not aligned with breadcrumb ([[#48](https://github.com/sovity/authority-portal/issues/48)]) - Fixed misleading UptimeKuma endpoint documentation ([#26](https://github.com/sovity/authority-portal/issues/26)) - Fixed components being displayed as online when UptimeKuma is unreachable - Cleaned up repository for open-source release: diff --git a/authority-portal-frontend/src/app/common/layouts/portal-layout/breadcrumb/breadcrumb.component.ts b/authority-portal-frontend/src/app/common/layouts/portal-layout/breadcrumb/breadcrumb.component.ts index 62d8437e4..10f911845 100644 --- a/authority-portal-frontend/src/app/common/layouts/portal-layout/breadcrumb/breadcrumb.component.ts +++ b/authority-portal-frontend/src/app/common/layouts/portal-layout/breadcrumb/breadcrumb.component.ts @@ -11,6 +11,7 @@ * sovity GmbH - initial implementation */ import {Component, OnDestroy} from '@angular/core'; +import {Title} from '@angular/platform-browser'; import {Subject, takeUntil} from 'rxjs'; import {BreadcrumbItem} from './breadcrumb.model'; import {BreadcrumbService} from './breadcrumb.service'; @@ -22,11 +23,17 @@ import {BreadcrumbService} from './breadcrumb.service'; export class BreadcrumbComponent implements OnDestroy { breadcrumb: BreadcrumbItem[] = []; - constructor(private breadcrumbService: BreadcrumbService) { + constructor( + private breadcrumbService: BreadcrumbService, + private titleService: Title, + ) { this.breadcrumbService.breadcrumb$ .pipe(takeUntil(this.ngOnDestroy$)) .subscribe((breadcrumb) => { this.breadcrumb = breadcrumb; + this.titleService.setTitle( + 'MDS ' + breadcrumb[breadcrumb.length - 1].label || 'Portal', + ); }); } diff --git a/authority-portal-frontend/src/favicon.ico b/authority-portal-frontend/src/favicon.ico deleted file mode 100644 index 997406ad22c29aae95893fb3d666c30258a09537..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 948 zcmV;l155mgP)CBYU7IjCFmI-B}4sMJt3^s9NVg!P0 z6hDQy(L`XWMkB@zOLgN$4KYz;j0zZxq9KKdpZE#5@k0crP^5f9KO};h)ZDQ%ybhht z%t9#h|nu0K(bJ ztIkhEr!*UyrZWQ1k2+YkGqDi8Z<|mIN&$kzpKl{cNP=OQzXHz>vn+c)F)zO|Bou>E z2|-d_=qY#Y+yOu1a}XI?cU}%04)zz%anD(XZC{#~WreV!a$7k2Ug`?&CUEc0EtrkZ zL49MB)h!_K{H(*l_93D5tO0;BUnvYlo+;yss%n^&qjt6fZOa+}+FDO(~2>G z2dx@=JZ?DHP^;b7*Y1as5^uphBsh*s*z&MBd?e@I>-9kU>63PjP&^#5YTOb&x^6Cf z?674rmSHB5Fk!{Gv7rv!?qX#ei_L(XtwVqLX3L}$MI|kJ*w(rhx~tc&L&xP#?cQow zX_|gx$wMr3pRZIIr_;;O|8fAjd;1`nOeu5K(pCu7>^3E&D2OBBq?sYa(%S?GwG&_0-s%_v$L@R!5H_fc)lOb9ZoOO#p`Nn`KU z3LTTBtjwo`7(HA6 z7gmO$yTR!5L>Bsg!X8616{JUngg_@&85%>W=mChTR;x4`P=?PJ~oPuy5 zU-L`C@_!34D21{fD~Y8NVnR3t;aqZI3fIhmgmx}$oc-dKDC6Ap$Gy>a!`A*x2L1v0 WcZ@i?LyX}70000Authority Portal - +