Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename stuff like options.js and /assets/ to names more sourcejs related #229

Open
ndelangen opened this issue May 28, 2016 · 1 comment

Comments

@ndelangen
Copy link
Member

Now that install by dependency is going to become the official way and the only way in 0.7.x I think we should think about being a bit less invasive upon people's environment.

Imagine if every npm dependency just asked to add a options.js to the root of the folder?
I propose we rename it to something like sourcejs.config.js if that's possible.

Also I think all template-overrides, assets overrides and core-overrides could be in a sourcejs folder by default, instead of in the root.
Another options would be to rename them to sourcejs-assets, sourcejs-templates.. etc.

@robhrt7
Copy link
Member

robhrt7 commented May 30, 2016

Hi,

My assumption always was that SourceJS should be defined as a dependency deeper in the tree, next to the project components. Do you see it's feasible to keep SourceJS as a dev dependency right in the root? In this case of course options.js is way too abstract. We can introduce an alternative name, with deprecation notice for the old one already in 0.6.0.

For the overrides, we definitely should namespace the core and assets folders, following the same deprecation flow as described above.

@robhrt7 robhrt7 added this to the 0.6.0 milestone May 30, 2016
@robhrt7 robhrt7 modified the milestones: 0.7.0, 0.6.0 Aug 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants