Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors for queries with imbalanced parentheses are reported only for too many left parentheses #547

Open
isker opened this issue Feb 25, 2023 · 1 comment · May be fixed by #569
Open

Errors for queries with imbalanced parentheses are reported only for too many left parentheses #547

isker opened this issue Feb 25, 2023 · 1 comment · May be fixed by #569

Comments

@isker
Copy link
Contributor

isker commented Feb 25, 2023

Here are some input query strings and the results of parsing them, including the error, if any. Some of them should result in parse errors but do not.

( -> <nil> (query: missing close paren, got token <nil>)
(( -> <nil> (error parsing regexp: missing closing ): `((`)
((( -> <nil> (error parsing regexp: missing closing ): `(((`)
() -> TRUE (<nil>)
) -> TRUE (<nil>) # should error
)) -> TRUE (<nil>) # should error
))) -> TRUE (<nil>) # should error
foo -> substr:"foo" (<nil>)
foo) -> substr:"foo" (<nil>) # should error
foo)) -> substr:"foo" (<nil>) # should error
foo))) -> substr:"foo" (<nil>) # should error
(foo -> <nil> (error parsing regexp: missing closing ): `(foo`)
((foo -> <nil> (error parsing regexp: missing closing ): `((foo`)
(((foo -> <nil> (error parsing regexp: missing closing ): `(((foo`)
(foo) -> substr:"foo" (<nil>)
(foo)) -> substr:"foo" (<nil>) # should error
((foo)) -> substr:"foo" (<nil>)
(((foo)) -> <nil> (error parsing regexp: missing closing ): `(((foo))`)
@keegancsmith keegancsmith linked a pull request Mar 27, 2023 that will close this issue
Draft
@keegancsmith
Copy link
Member

I took a quick look at this and have a potential solution at #569. However, I don't fully understand the nitty gritty of the parse functions so needs more testing/review before taking further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

wip handle parse function not consuming all of input sourcegraph/zoekt
2 participants
@keegancsmith @isker