This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
rename 'Enterprise licenses' to 'Enterprise subscriptions' to accurately represent enterprise accounts #61049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ely represent enterprise accounts
bobheadxi
force-pushed
the
rename-enterprise-subscriptions
branch
from
9707a5b to
1be8dfb
Compare
sqs
approved these changes
Mar 13, 2024
eseliger
approved these changes
Mar 13, 2024
This was referenced Mar 13, 2024
PR is in sourcegraph/handbook#8710, and sourcegraph/docs#150 for docs as well 😄 |
bobheadxi
referenced
this pull request
in sourcegraph/handbook
Mar 13, 2024
Partial revert of #8684 to apply the clearer `Enterprise subscriptions` naming - see https://github.com/sourcegraph/sourcegraph/pull/61049
bobheadxi
referenced
this pull request
in sourcegraph/docs
Mar 13, 2024
Partially revert #125 - see https://github.com/sourcegraph/sourcegraph/pull/61049. In particular #125 introduced some errors about how Cody Gateway properties are evaluated, notably very few Cody Gateway access properties are evaluated from license keys. While here I also found another error - there's a table indicating the product subscription token is `not derived from a Sourcegraph license key`, but it _is_ derived from the license key, which is how the zero-config Cody mechanism works. I've fixed this in this PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/sourcegraph/sourcegraph/pull/60911 renamed "Subscriptions" to "Enterprise licenses", but the two are not equivalent, as "subscriptions" are an entity above individual licenses - for example
Create new Enterprise licenseis not equivalent to the previousCreate new product subscription. This entity is important because there are some elements of these subscriptions that are more subscription-oriented, than license-oriented - for example, Cody Gateway rate limits exist at an "Enterprise subscription" level and are not necessarily tied to individual licenses (though they can affect what is evaluated at the "subscription" level).In RFC 885 Sourcegraph Enterprise Portal outlining how Core Services plans to change this area (and also the existing use cases of a "subscription"-like entity), we've taken to referring to these as "Enterprise subscriptions" to differentiate from PLG ones. This naming more accurately reflects the model while avoiding confusion with PLG subscriptions.
See thread: https://sourcegraph.slack.com/archives/C04MEF2T33M/p1710292839852869?thread_ts=1709789262.898779&cid=C04MEF2T33M
This PR applies the new naming and also fixes a few spots missed in https://github.com/sourcegraph/sourcegraph/pull/60911
Test plan
sg start dotcom