Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Make the token scopes POC production ready #42935

Closed
7 tasks
kopancek opened this issue Oct 13, 2022 · 1 comment
Closed
7 tasks

Make the token scopes POC production ready #42935

kopancek opened this issue Oct 13, 2022 · 1 comment
Labels
team/source Tickets under the purview of Source - the one Source to graph it all

Comments

@kopancek
Copy link
Contributor

kopancek commented Oct 13, 2022

Based on the RFC definition:

We have an open PR with a POC for token scopes in the API:

To make the POC production ready, we need to work on several subtasks:

  • Make the code more readable, understandable, better structured and following our conventions
  • Use graph-gophers/graphql with support for graphql directives
  • Add UI to be able to generate token with newly added scopes
  • Add the directive to more entities in graphql and decide which scopes each entity should have
  • Add proper tests and make sure it does not have a big performance hit on critical parts of the system
  • Define a process for token scope conventions
  • Add scope list to the schema, so only a specific list of scopes can be attached

/cc @sourcegraph/source/iam

@kopancek kopancek self-assigned this Oct 13, 2022
@ryphil ryphil moved this from To Do to Backlog in IAM Team Nov 7, 2022
@malomarrec
Copy link
Contributor

Hey @kopancek, this issue didn't have a team label. Given you created it, I assigned you and added your team label. Feel free to unassign yourself. If this is not the right label, can you make sure to add the right one?

@mrnugget mrnugget added the team/source Tickets under the purview of Source - the one Source to graph it all label Jul 13, 2023
@eseliger eseliger removed the iam label Oct 9, 2023
@eseliger eseliger closed this as not planned Won't fix, can't repro, duplicate, stale Feb 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team/source Tickets under the purview of Source - the one Source to graph it all
Projects
No open projects
Status: Backlog
Development

No branches or pull requests

4 participants