Web: 3.20 Tracking issue

[felixfbecker]

Plan

For 3.20, the web team continues on their focus started last iteration to improve UI/UX, consistency and discoverability in the web app. We want to implement @quinnkeast's improvements of the sign-in/sign-out flow. In the theme of improving discoverability, we want to kick off the project to improve browser extension discoverability (RFC 221) so we can implement it in 3.21. This needs to be designed first, but from our retrospective learnings we will involve ourselves in the design process from the start.

Leading to our medium term goal (2) of bringing the extensions platform into shape while connecting it with UI/UX improvements of the webapp, we will improve the UI/UX of the extensions registry, a project @AlicjaSuska has worked on and @tjkandala has done some work on as part of his onboarding. This is part of RFC 209.

We also need to follow-up with a solution to test extensions with our new integration test suite, which is a prerequisite to have anything to test in the browser extension, important for our long-term goal around extensions and to allow other teams (code intel) to build on well-tested code.

Availability

If you have planned unavailability this iteration (e.g., vacation), you can note that here.

• Felix: 2 weeks vacation 2020-09-07 - 2020-09-18

Tracked issues

@unassigned

• RFC 221 Tracking issue: Improve discoverability/awareness of the browser extension (#14165)

@felixfbecker: 1.00d

Completed: 1.00d

• (🏁 28 days ago) 'About Sourcegraph' and 'Help' pages should be opened in the separate tab (#12286) 0.5d
• (🏁 26 days ago) Rendering of Directory Children With Single Folder Is Confusing (#13231) 0.5d 🐛👩

@marekweb: 1.00d

• Investigate creation of Safari browser extension (#13499) 1d 🕵️

Completed

• (🏁 20 days ago) Add opt-in option for Firefox browser extension telemetry (#13377)
• (🏁 10 days ago) Produce a source code zip of Firefox add-on to faciliate compliance review (#12918; PRs: #12099)

@quinnkeast

• Adding a repository with improper credentials does not properly warn the user. (#13634)

@tjkandala: 15.00d

• Implement UI changes on sign-in/sign-up form (#13443) 2d
• Show error messages from third-party auth on sign-in page instead of on a plain text, white background plain HTML page (#13442) 2d
• Remove sign out page (#13440) 0.5d
• Create extensions for opening in additional editors - Atom, IntelliJ and Sublime Text (#13270) 0.5d

Completed: 10.00d

• (🏁 20 days ago) Disable other extensions when sideloading (#13586)
• (🏁 16 days ago) Improve command palette (#13305)
• (🏁 16 days ago) Update toggle with new styling, add big toggle (#13272) 2.5d
• (🏁 14 days ago) Change language from "Sign in with $AUTH_PROVIDER" to "Continue with $AUTH_PROVIDER" (#13441) 0.5d
• (🏁 13 days ago) Improve the open-in-editor extension (#13474)
• (🏁 13 days ago) Last breadcrumb should not be a link on non-repo pages (#13651) 0.5d
• (🏁 today) Add custom confirmation popup when enabling the extension (#13664) 1d
• (🏁 today) Toggles on the extensions registry are higher on the z-axis than the command palette (#13781) 0.5d 🐛
• (🏁 today) RFC 209: Extensions Discoverability (#13329; PRs: #12810, #13699) 4d
• (🏁 today) Some extensions need a dark mode variant (#13666) 1d

Legend

• 👩 Customer issue
• 🐛 Bug
• 🧶 Technical debt
• 🛠️ Roadmap
• 🕵️ Spike
• 🔒 Security issue
• Pull Request

[tjkandala]

Last week I mostly worked to complete the changes proposed in RFC 209. I worked on the new toggle component, changes to the command palette, and updated styles for the extension registry. I also reviewed RFCs 213 and 221, and got started on some RFC 213 issues.

Next week I plan to implement the remaining RFC 209 changes once the toggle PR is merged. I also plan to help the team complete the sign in/out UX changes from RFC 213.

[marekweb]

Last week most of my coding work was on the browser extension and the refactor of feature flags, which is part of the work to update the Firefox add-on. That work went beyond my initial estimate but I also decided to include a bit more refactoring work that I initially planned. I also reviewed RFCs, and I had hiring interviews.

This week I'm wrapping up that add-on work and I'm moving on to the sign in/out UX tasks that are part of the milestone. I also intend to start investigating the Safari WebExtensions support.

[tjkandala]

Last Week I implemented the remaining changes from RFC 209 (extension registry), as well as further changes from Felix's review, and got approval from Felix in time for his vacation. I made further progress on RFC 213 (sign in/out) issues, but realized that I needed more context on auth, which I looked into. I also made small changes to extension code that I plan to merge this week.

This Week I will merge the disparate RFC 209 branches before continuing work on the auth aspects of the sign in/out changes. I also plan to complete the open-in-editor extensions.

[tjkandala]

Last Week

I implemented some new changes to the extension registry, made some changes to extensions, and worked on auth.

Extension Registry

• Implemented new animation for enabled extensions. Wrote React hook to abstract timeout management for this and future animations (Add useTimeoutManager hook #13749)
• Refactored ExtensionToggle to enable proper (non-blocking) modal when adding extensions, then implemented the modal.

Extensions

• Disable extension when sideloading (DX change)
• Add ability to specify dark-theme icon (Add themed icons to extensions #13703)

Auth

• Read auth + session-related code, then helped with the web portion of the explicit session invalidation PR.
• With the knowledge gained from working on the previously mentioned issue, finished an RFC213 issue and started working on others.

This week
I plan to wrap up work for this iteration by merging hanging PRs, then dedicating a few days to sign in/out UX issues.

[davejrt]

Dear all,

This is your release captain speaking. 🚂🚂🚂

Branch cut for the 3.20 release is scheduled for tomorrow.

Is this issue / PR going to make it in time? Please change the milestone accordingly.
When in doubt, reach out!

Thank you

[marekweb]

Last week

I debugged the request interception work-in-progress that will allow for extension testing, and which is being tracked in #12194. I started on the sign-in/sign-out UI changes. I started research on the potential development of the Safari extension. I made some changes to the browser extension build scripts, and also produced a new source code package for the FF add-on. I found an improved way to fetch the code-intel-extensions repository for bundling in Firefox.

This week

I'm focusing on the sign-in/sign-out UI work at the start of the week, and after branch cut I'll revisit the other priorities including the request interception for extension testing. Because of interest from the product team, I'll continue investigating the Safari extension.