Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional sql support for Docker/Docker-Compose #140

Open
therealkevinard opened this issue Oct 9, 2020 · 1 comment
Open

Optional sql support for Docker/Docker-Compose #140

therealkevinard opened this issue Oct 9, 2020 · 1 comment

Comments

@therealkevinard
Copy link

sqlite support does require a larger image and build time, but certainly has its benefits vs fs.

The repository should provide optional support for smoother on-boarding for those who prefer a sql-backed solution.
@therealkevinard therealkevinard mentioned this issue Oct 9, 2020
Open
therealkevinard pushed a commit to therealkevinard/checkup that referenced this issue Oct 9, 2020
deployment: optional support for sqlite
89eecf4 
adds optional dockerfile and docker-compose with sqlite
support/config. adds make target for alternate build.

addresses sourcegraph#140
@therealkevinard therealkevinard mentioned this issue Oct 9, 2020
Closed
@titpetric
Copy link
Contributor

titpetric commented Oct 9, 2020 •
edited
Loading

Could you build this with alpine, both for the builder and the final images? apk add sqlite and a particular symlink should be enough to create a CGO build, and then just install this into the final image too - possibly deleting the sqlite cli client to save a few bytes. (RUN apk add sqlite && rm /usr/bin/sqlite or whatever the path in the final image)

therealkevinard pushed a commit to therealkevinard/checkup that referenced this issue Oct 9, 2020
deployment: optional support for sqlite
e14c137 
adds optional dockerfile and docker-compose with sqlite
support/config. adds make target for alternate build.

addresses sourcegraph#140
therealkevinard pushed a commit to therealkevinard/checkup that referenced this issue Oct 9, 2020
deployment: optional support for sqlite
3cd90aa 
adds optional dockerfile and docker-compose with sqlite
support/config. adds make target for alternate build.

addresses sourcegraph#140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@titpetric @therealkevinard