From 3a3aa9a16c0d8c55bff264a13e66e8ddf40a7a2a Mon Sep 17 00:00:00 2001 From: sadarunnisa Date: Thu, 26 Dec 2024 05:44:32 +0530 Subject: [PATCH 1/3] Update presets.ts --- .../src/components/BuildsPage/lib/CITable/presets.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/jenkins-with-reporting/src/components/BuildsPage/lib/CITable/presets.ts b/plugins/jenkins-with-reporting/src/components/BuildsPage/lib/CITable/presets.ts index 828e035..adea29f 100644 --- a/plugins/jenkins-with-reporting/src/components/BuildsPage/lib/CITable/presets.ts +++ b/plugins/jenkins-with-reporting/src/components/BuildsPage/lib/CITable/presets.ts @@ -22,7 +22,7 @@ export const defaultCITableColumns: TableColumn[] = [ columnFactories.createTimestampColumn(), columnFactories.createSourceColumn(), columnFactories.createBuildColumn(), - columnFactories.createTestColumn(), + // columnFactories.createTestColumn(), //NOSONAR columnFactories.createStatusColumn(), columnFactories.createLastRunDuration(), columnFactories.createActionsColumn(), From 0df112186e6339c8d8af1675684bdf7ea7352369 Mon Sep 17 00:00:00 2001 From: sadarunnisa Date: Thu, 26 Dec 2024 05:56:58 +0530 Subject: [PATCH 2/3] Update columns.tsx --- .../BuildsPage/lib/CITable/columns.tsx | 74 ++++++++++--------- 1 file changed, 38 insertions(+), 36 deletions(-) diff --git a/plugins/jenkins-with-reporting/src/components/BuildsPage/lib/CITable/columns.tsx b/plugins/jenkins-with-reporting/src/components/BuildsPage/lib/CITable/columns.tsx index 68e8a04..cf0e003 100644 --- a/plugins/jenkins-with-reporting/src/components/BuildsPage/lib/CITable/columns.tsx +++ b/plugins/jenkins-with-reporting/src/components/BuildsPage/lib/CITable/columns.tsx @@ -43,46 +43,48 @@ const SkippedCount = ({ count }: { count: number }): JSX.Element | null => { return null; }; -const FailSkippedWidget = ({ - skipped, - failed, -}: { - skipped: number; - failed: number; -}): JSX.Element | null => { - if (skipped === 0 && failed === 0) { - return null; - } +// @SonarIgnoreStart +// const FailSkippedWidget = ({ +// skipped, +// failed, +// }: { +// skipped: number; +// failed: number; +// }): JSX.Element | null => { +// if (skipped === 0 && failed === 0) { +// return null; +// } - if (skipped !== 0 && failed !== 0) { - return ( - <> - {' '} - (, ) - - ); - } +// if (skipped !== 0 && failed !== 0) { +// return ( +// <> +// {' '} +// (, ) +// +// ); +// } - if (failed !== 0) { - return ( - <> - {' '} - () - - ); - } +// if (failed !== 0) { +// return ( +// <> +// {' '} +// () +// +// ); +// } - if (skipped !== 0) { - return ( - <> - {' '} - () - - ); - } +// if (skipped !== 0) { +// return ( +// <> +// {' '} +// () +// +// ); +// } - return null; -}; +// return null; +// }; +// @SonarIgnoreEnd export const columnFactories = Object.freeze({ createTimestampColumn(): TableColumn { From eb13ce97f83306400d8dcdca7334a8f6155cd2f0 Mon Sep 17 00:00:00 2001 From: sadarunnisa Date: Thu, 26 Dec 2024 06:04:16 +0530 Subject: [PATCH 3/3] Update columns.tsx --- .../BuildsPage/lib/CITable/columns.tsx | 27 ++++++++++--------- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/plugins/jenkins-with-reporting/src/components/BuildsPage/lib/CITable/columns.tsx b/plugins/jenkins-with-reporting/src/components/BuildsPage/lib/CITable/columns.tsx index cf0e003..551b151 100644 --- a/plugins/jenkins-with-reporting/src/components/BuildsPage/lib/CITable/columns.tsx +++ b/plugins/jenkins-with-reporting/src/components/BuildsPage/lib/CITable/columns.tsx @@ -29,21 +29,22 @@ import { buildRouteRef, jobRunsRouteRef } from '../../../../plugin'; import { JenkinsRunStatus } from '../Status'; import { jenkinsExecutePermission } from '@backstage-community/plugin-jenkins-common'; -const FailCount = ({ count }: { count: number }): JSX.Element | null => { - if (count !== 0) { - return <>{count} failed; - } - return null; -}; +// @SonarIgnoreStart +// const FailCount = ({ count }: { count: number }): JSX.Element | null => { +// if (count !== 0) { +// return <>{count} failed; +// } +// return null; +// }; + +// const SkippedCount = ({ count }: { count: number }): JSX.Element | null => { +// if (count !== 0) { +// return <>{count} skipped; +// } +// return null; +// }; -const SkippedCount = ({ count }: { count: number }): JSX.Element | null => { - if (count !== 0) { - return <>{count} skipped; - } - return null; -}; -// @SonarIgnoreStart // const FailSkippedWidget = ({ // skipped, // failed,