Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't read null property when setting match #7

Open
antoinepetty opened this issue Jul 10, 2020 · 7 comments
Open

Can't read null property when setting match #7

antoinepetty opened this issue Jul 10, 2020 · 7 comments

Comments

@antoinepetty
Copy link

image
Captured from chrome developer console when running with a local copy of sr-comp

@antoinepetty
Copy link
Author

antoinepetty commented Jul 10, 2020

I have just noticed that the total league matches is 0 which is a little odd

@antoinepetty
Copy link
Author

When running with the SR settings I don't get the above exception so there's probably something wrong with my compstate

var streamServerURI = "https://srcomp.studentrobotics.org/stream";
var apiURI = "https://srcomp.studentrobotics.org/comp-api/";

image

@antoinepetty
Copy link
Author

I get the issue when running locally with https://github.com/PeterJCLaw/dummy-comp

@PeterJCLaw
Copy link

This is a genuine bug in the overlay. The issue is that the API is returning that there isn't a next match, but the overlay isn't handling that case.

This only happens after all the matches have happened, which is the case for the dummy comp because it's all in the past, yet not for the live API as that's in the future.

@PeterJCLaw
Copy link

Hrm, having had a look at how getNextMatch works, it's all in the livestream. There is an API to get the current match, but it's not being used.

@PeterJCLaw
Copy link

(This all being in the livestream is also a bug as it relies on the local time being in step with the competition time, which it may not be, but that's definitely a different issue)

@antoinepetty
Copy link
Author

This only happens after all the matches have happened, which is the case for the dummy comp because it's all in the past, yet not for the live API as that's in the future.

I still get the issue after changing the dates to be between 2020-07-09 and 2020-07-12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants