Fix version upgrade toast refresh issue #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msukkari
approved these changes
Jan 25, 2025
brendan-kellam
force-pushed
the
bkellam/fix_version_toast
branch
from
db4ca65 to
b2ea4e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a issue where the version upgrade toast only appeared after force-refreshing the browser, even when a new version was available.
Previously, the client was getting the current Sourcebot version via a client-side environment variable that is baked into the JS bundles at build time. There is some weirdness with how those bundles are refreshed on the browser (I think), which is why a hard refresh is required.
The fix is to add a
/api/versionapi route that will fetch the Sourcebot version from a server-side environment variable.