Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSG 2.0]: Side buttons not clickable #214

Closed
RichDom2185 opened this issue May 29, 2023 · 3 comments
Closed

[CSG 2.0]: Side buttons not clickable #214

RichDom2185 opened this issue May 29, 2023 · 3 comments
Labels
Bug [Category]

Comments

@RichDom2185
Copy link
Member

Prerequisites

Run any program that renders the CSG tab.

Expected Behavior

Side buttons would be clickable.

Current Behavior

Side buttons cannot be interacted with (except hover, which shows the tooltip). One can still use the mouse controls given in those tooltips to interact with the "canvas" directly.

image

Context

  • Version used: f72e5a1
  • Browser Name and version: Chrome 113
  • Operating System and version (desktop or mobile): macOS 13.4 (arm64)
@RichDom2185 RichDom2185 added the Bug [Category] label May 29, 2023
@Cloud7050
Copy link
Contributor

Click functionality was not added to the hints in V1 (Cloud7050#23). There are a few remaining enhancements/bugs left over from CSG V1 which live as issues in its fork. I'm not fully aware of what V2 planned to implement.

But on a related note, the tooltips should be changed to use BlueprintJS ones as I heard we have the technology for modules to do so now. The current ones were custom CSS that would sometimes float strangely depending on the width of the sidebar.

@Cloud7050
Copy link
Contributor

I am currently making some edits to the CSG hover control hints. I do not think V2 intended to turn them into buttons.

I am closing this bug as I think the components are working as intended, but this would definitely be a nice enhancement to have. It is currently still listed as an enhancement in the V1 fork (Cloud7050#23). When I transfer the fork's remaining issues over to this repo, I will create an issue of a similar nature, but as an enhancement.

@Cloud7050
Copy link
Contributor

See also #229

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug [Category]
Projects
None yet
Development

No branches or pull requests

2 participants