Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roll_min and roll_max can mean different things for different roll_options? #99

Open
jeanconn opened this issue Feb 28, 2019 · 1 comment
Labels
documentation enhancement New feature or request

Comments

@jeanconn
Copy link
Contributor

jeanconn commented Feb 28, 2019

I think we talked about it, but I'm not sure if it is documented anywhere. So, roll options are configured so the 0-index roll-option will be the supplied/as-schedule/real roll of the observation being reviewed. The 0-index roll option looks to have roll_max and roll_min just set to be roll. That's fine, but I think it is conceptually different from roll_min/roll_max on the other "solved" roll options where each is intended to describe the range that you get with about the same catalog, right?

@taldcroft
Copy link
Member

Good point. This can be a future enhancement to make roll_min/max in that 0th-option case work like you said.

@jeanconn jeanconn added the enhancement New feature or request label Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants