Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"headers" option not used when rendering the page. #82

Open
bhumikaSinghal opened this issue Apr 17, 2015 · 1 comment
Open

"headers" option not used when rendering the page. #82

bhumikaSinghal opened this issue Apr 17, 2015 · 1 comment

Comments

@bhumikaSinghal
Copy link

I wanted to use the Basic Auth headers while rendering the page using phatomJs. However, even though I set this var while defining the var render, it is not reflected/used.

If I modify the following in index.js:
ropts = xtend({
url : url,
quality:opts.quality,
format : opts.format,
printMedia : opts.printMedia,
expects : opts.expects,
timeout : opts.timeout
}, ropts);

to:

ropts = xtend({
url : url,
quality:opts.quality,
format : opts.format,
printMedia : opts.printMedia,
expects : opts.expects,
timeout : opts.timeout,
headers : opts.headers
}, ropts);

then the page renders fine. If this is the case then this ropts object is missing other options that can be set and thus index.js should be updated. Is this the correct approach or am I missing something?

@hulvei3
Copy link
Contributor

hulvei3 commented Mar 3, 2016

#85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants