Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement ifelsetree via TypeVisitor #970

Open
swissiety opened this issue Jul 5, 2024 · 2 comments · May be fixed by #998
Open

implement ifelsetree via TypeVisitor #970

swissiety opened this issue Jul 5, 2024 · 2 comments · May be fixed by #998
Labels
good first issue Good for newcomers improvement improve in readability, structure or performance

Comments

@swissiety
Copy link
Collaborator

What happened?

see Type.java:66

Version

Latest develop branch

Relevant log output

No response
@swissiety swissiety added good first issue Good for newcomers improvement improve in readability, structure or performance labels Jul 5, 2024
skmuduli92 added a commit to skmuduli92/SootUp that referenced this issue Jul 29, 2024
@skmuduli92
This change addresses the issue soot-oss#970.
d1840d9 
Implemented a type visitor for computing the bitsize of a given type.
skmuduli92 added a commit to skmuduli92/SootUp that referenced this issue Jul 29, 2024
@skmuduli92
This change resolves soot-oss#970
07cf5e6 
Implemented a type visitor for computing the bitsize of a given type
@skmuduli92 skmuduli92 linked a pull request Jul 29, 2024 that will close this issue
Draft
@skmuduli92
Copy link

@swissiety
Hi Markus,

I tried to implement this, if not already resolved please review it. Please share your inputs if the pull request requires some changes.

Thanks.

@swissiety
Copy link
Collaborator Author

Thx for your contribution!
We are reworking the visitors in the near future - it would be great if you could implement your own getresult method and the associated field in the visitor as we want to remove these from the abstractvisitor - that way e.g. no unnecessary boxing would be required in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers improvement improve in readability, structure or performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Type visitor implimentation for computing the bitsize (issue #970) skmuduli92/SootUp
2 participants
@skmuduli92 @swissiety