Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use code signing to prove trustworthiness #45

Open
maxbechtold opened this issue Jul 5, 2020 · 3 comments
Open

Use code signing to prove trustworthiness #45

maxbechtold opened this issue Jul 5, 2020 · 3 comments

Comments

@maxbechtold
Copy link
Collaborator

maxbechtold commented Jul 5, 2020

Code signing the timerecord.exe should prevent "Unknown publisher" dialogs or at least display a name related to this GitHub project (since only self-signing seems to be free nowadays).
https://github.com/pyinstaller/pyinstaller/wiki/Recipe-Win-Code-Signing
https://stackoverflow.com/a/51443366
https://www.cryptosys.net/pki/manpki/pki_distnames.html

Since this only signs the executable, it might be prudent to provide a hash sum for the individual bundle zips.

Signing .bat files is not possible, so there should be at least some docs explaining how to cope with it when listing or exporting stage times: https://superuser.com/questions/470463/how-to-sign-a-windows-batch-bat-file

maxbechtold added a commit that referenced this issue Jul 10, 2020
maxbechtold added a commit that referenced this issue Jul 11, 2020
maxbechtold added a commit that referenced this issue Jul 19, 2020
maxbechtold added a commit that referenced this issue Jul 19, 2020
maxbechtold added a commit that referenced this issue Jul 27, 2020
maxbechtold added a commit that referenced this issue Jul 27, 2020
maxbechtold added a commit that referenced this issue Jul 27, 2020
maxbechtold added a commit that referenced this issue Jul 27, 2020
maxbechtold added a commit that referenced this issue Jul 27, 2020
maxbechtold added a commit that referenced this issue Jul 27, 2020
maxbechtold added a commit that referenced this issue Jul 27, 2020
maxbechtold added a commit that referenced this issue Jul 27, 2020
@maxbechtold
Copy link
Collaborator Author

Perhaps submitting the executable for analysis could increase its reputation. This would have to be done for every bundle of every release.
https://www.microsoft.com/en-us/wdsi/filesubmission/

@maxbechtold
Copy link
Collaborator Author

MS SmartScreen Defender still shows a warning with "Unknown Publisher" for the signed executable. Probably this data is taken from the .exe directly, and could be added as described here: https://pyinstaller.readthedocs.io/en/stable/usage.html#capturing-windows-version-data. This info, together with the bundle hash sum, should convince users that timerecord.exe is genuine.

Unfortunately, I can't get it to work with the current PyInstaller stable version, I should try it once 4.0 is released.

@maxbechtold
Copy link
Collaborator Author

The Defender warning might also be related to the "MOTW" flag of the exe that might be set on downloading of the release. To analyze this, https://github.com/nmantani/PS-MOTW might be helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant