Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activation memory estimation (in resource utilization) ignores layers where the activation quantization disabled #1293

Open
elad-c opened this issue Dec 15, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@elad-c
Copy link
Collaborator

elad-c commented Dec 15, 2024

Issue Type

Bug

Source

source

MCT Version

nightly

OS Platform and Distribution

No response

Python version

No response

Describe the issue

Currently unquantized vectors size are ignored in MaxTensor and MaxCut. Need to handle according to the quantization preserving flag.

Expected behaviour

No response

Code to reproduce the issue

Node torch.expand might cause an issue (untreated increased tensor size).

Log output

No response

@haihabi
Copy link
Collaborator

haihabi commented Dec 15, 2024

@ofirgo and @elad-c this should be handled using quantization preserving.

@ofirgo ofirgo added the enhancement New feature or request label Jan 6, 2025
@ofirgo ofirgo changed the title Activation memory estimation (in resource utilization) ignores layers the activation quantization disabled Activation memory estimation (in resource utilization) ignores layers where the activation quantization disabled Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants