You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First of all, thank you for your great contribution.
Can you please remove this condition, as I don't think it's quite needed because if the command is not executable then there will be an error when trying to open the URL anyway. Additionally, I have one use case that cannot be fulfilled with this condition checking as follows: I am using WSL, and I need to open the URL by a Windows command so that it will be opened in a Windows browser not the other way around. And, the way to do this is by having this command: cmd.exe /C start $url yet it fails the executable condition as it is not an application but a whole command.
So, please consider removing this. Thank you.
Edit1: ủa Vietnamese huh? Xin chào đồng chí =)))
Edit2: we can also modify the "default" app behavior when using WSL to open by a Windows browser as well, as while opening the URL in a WSL browser is possible, the experience is still very sluggish. This is how you can detect WSL: uname.release:lower():find("microsoft") and true or false. Also, if you are okay with it, I can make a pull request for this.
First of all, thank you for your great contribution.
Can you please remove this condition, as I don't think it's quite needed because if the command is not executable then there will be an error when trying to open the URL anyway. Additionally, I have one use case that cannot be fulfilled with this condition checking as follows: I am using WSL, and I need to open the URL by a Windows command so that it will be opened in a Windows browser not the other way around. And, the way to do this is by having this command:
cmd.exe /C start $url
yet it fails the executable condition as it is not an application but a whole command.So, please consider removing this. Thank you.
Edit1: ủa Vietnamese huh? Xin chào đồng chí =)))
Edit2: we can also modify the "default" app behavior when using WSL to open by a Windows browser as well, as while opening the URL in a WSL browser is possible, the experience is still very sluggish. This is how you can detect WSL:
uname.release:lower():find("microsoft") and true or false
. Also, if you are okay with it, I can make a pull request for this.url-open/lua/url-open/modules/handlers.lua
Line 109 in 9f8f4a5
The text was updated successfully, but these errors were encountered: