Skip to content

Keyboard shortcuts do not fully support a range of locales #1734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
simongray opened this issue Sep 23, 2017 · 5 comments
Closed

Keyboard shortcuts do not fully support a range of locales #1734

simongray opened this issue Sep 23, 2017 · 5 comments

Comments

@simongray
Copy link

simongray commented Sep 23, 2017

Currently, the keyboard shortcuts are biased towards English keyboard layouts (en_US, en_UK, etc.) and unfortunately cannot be customised by users in any way. This means that any keyboard shortcuts that feature a key that is non-standard in a certain locale is inaccessible to all of those users.

Shortcuts such as M-/ for line comment/uncomment are thus inaccessible to users whose keyboards do not have "/" as a stand-alone key on the keyboard. This is the case in for example German, Swedish, and Danish where "/" is an alternative symbol that is accessed by also holding down shift. The same holds true for shortcuts such as M-{ and M-< which are also inaccessible on e.g. Danish keyboards.

@samaaron
Copy link
Collaborator

Yes, this is unfortunately a known problem. We’d love some help making things more configurable for non-us/uk keyboards :)

@simongray
Copy link
Author

@samaaron I would love to help, but I'm not familiar with the source code currently (only just started dabbling with Sonic Pi). Is there a single config file that controls the mapping of the keyboard shortcuts? Then at least the more technically inclined might edit the source directly as a temporary solution.

@simongray
Copy link
Author

@samaaron the keybindings are all hardcoded in the section of this one C++ file, right?

So I guess the immediate solution is to move the definitions to an external config file. I need to build it on a Mac and the only build instruction I could so far find is this. Is there anything else to know?

@samaaron
Copy link
Collaborator

@simongray - yep, you're right it is currently all hardcoded and it would be lovely to start extracting it out to a more configurable code base.

Unfortunately building Sonic Pi is non-trivial, but do have a go and let us know if you're running into issues.

@samaaron
Copy link
Collaborator

Closing as this is a duplicate of #1693 - please head over there to continue the conversation :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants