[action] [PR:14746] MIGSMSFT-647 improve qos/test_qos_sai.py to have different longlink/shortlink combinations #14821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description of PR Summary: Fixes MIGSMSFT-647 Approach What is the motivation for this PR? Have different combinations of longlink and shortlink in test_qos_sai.py. How did you do it? Extend params in select_src_dst_dut_and_asic. How did you verify/test it? Verified on T2 testbed which has 3 linecards, 1st linecard longlink, 2nd linecard shortlink, 3rd linecard shortlink. ---------------------------------------------- generated xml file: /tmp/qos/test_qos_sai.py::TestQosSai::testParameter_2024-09-25-20-41-38.xml ----------------------------------------------- ----------------------------------------------------------------------------------- live log sessionfinish ----------------------------------------------------------------------------------- 21:08:01 __init__.pytest_terminal_summary L0067 INFO | Can not get Allure report URL. Please check logs ================================================================================== short test summary info =================================================================================== PASSED qos/test_qos_sai.py::TestQosSai::testParameter[single_asic] PASSED qos/test_qos_sai.py::TestQosSai::testParameter[single_dut_multi_asic] PASSED qos/test_qos_sai.py::TestQosSai::testParameter[multi_dut_longlink_to_shortlink] PASSED qos/test_qos_sai.py::TestQosSai::testParameter[multi_dut_shortlink_to_shortlink] PASSED qos/test_qos_sai.py::TestQosSai::testParameter[multi_dut_shortlink_to_longlink] ========================================================================= 5 passed, 1 warning in 1581.20s (0:26:21) ========================================================================== INFO:root:Can not get Allure report URL. Please check logs sonic@sonic-ucs-m6-4:/data/tests$ [multi_dut_longlink_to_shortlink]: src_dut_index=0;src_asic_index=0;dst_dut_index=1;dst_asic_index=0 [multi_dut_shortlink_to_shortlink]: src_dut_index=1;src_asic_index=0;dst_dut_index=2;dst_asic_index=0 [multi_dut_shortlink_to_longlink]: src_dut_index=1;src_asic_index=0;dst_dut_index=0;dst_asic_index=0 Verified on T1, no impact on T1. ------------------------------------------------- generated xml file: /tmp/qos/test_qos_sai.py::TestQosSai::testParameter_2024-09-27-18-34-12.xml ------------------------------------------------- INFO:root:Can not get Allure report URL. Please check logs ------------------------------------------------------------------------------------- live log sessionfinish -------------------------------------------------------------------------------------- 18:38:06 __init__.pytest_terminal_summary L0067 INFO | Can not get Allure report URL. Please check logs ===================================================================================== short test summary info ===================================================================================== PASSED qos/test_qos_sai.py::TestQosSai::testParameter[single_asic] SKIPPED [1] qos/test_qos_sai.py:315: Did not find any frontend node that is multi-asic - so can't run single_dut_multi_asic tests SKIPPED [3] qos/test_qos_sai.py:315: multi-dut is not supported on T1 topologies ======================================================================= 1 passed, 4 skipped, 1 warning in 232.24s (0:03:52) ======================================================================= sonic@sonic-ucs-m5-8:/data/tests$ Signed-off-by: Zhixin Zhu <[email protected]>
|
Original PR: #14746 |
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes MIGSMSFT-647
Type of change
Back port request
Approach
What is the motivation for this PR?
Have different combinations of longlink and shortlink in test_qos_sai.py.
How did you do it?
Extend params in select_src_dst_dut_and_asic.
How did you verify/test it?
Verified on T2 testbed which has 3 linecards, 1st linecard longlink, 2nd linecard shortlink, 3rd linecard shortlink.
Verified on T1, no impact on T1.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation