New deploy-mg causes TSA to be in config_db (and golden), causing test errors when startup_tsa_tsb is disabled

[Javier-Tan]

Issue Type

Enhancement

Description

Since TSA/TSB was changed to start on swss startup (sonic-net/sonic-buildimage#21587), deploy-mg causes tsa_enabled: true in config_db. This could affect tests

If tsa_enabled is not explicitly set to false and saved to config before running tests, tsa_enabled will remain in the config, which is not desired (and deploy-mg is a common setup step before running nightly tests). Additionally pretest will save this to golden config.

In the case where pretest is run, startup_tsa_tsb service will be disabled, meaning any config reload will cause tsa_enabled to be on indefinitely causing test failures

This also causes "Core dump or config check failed" and triggers config reload, causing 15m per test delay

Issue Details

To recreate this issue:

Run deploy-mg on device and check tsa_enabled in config_db

Impact or Proposed Behavior

In general, tsa_enabled should be false for both config_db.json and golden_config_db.json

Importance or Severity

High

Is it platform specific

generic

Relevant log output

N/A

Output of show version

N/A

Attach files (if any)

N/A

[rlhui]

@Javier-Tan , can we please have a more descriptive title for this issue?

[Javier-Tan]

@rlhui done, sorry not sure why the title didnt save