Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test Gap][LAG][t0-64] Applying lag members configuration is not awaited #17095

Open
illia-kotvitskyi opened this issue Feb 21, 2025 · 0 comments

Comments

@illia-kotvitskyi
Copy link
Contributor

illia-kotvitskyi commented Feb 21, 2025

Test Gap Description

As part of test_lag_member_forwarding_packets test we disable portchannel members by swssconfig.

Once the swssconfig command finished, we are sending traffic to ensure it will be dropped.

The issue here is that swssconfig command finished its execution before the config actually was applied:

Test logs:
AnsibleModule::shell Result => {"changed": true, "stdout": "", "stderr": "", "rc": 0, "cmd": "docker exec -i swss swssconfig /dev/stdin < /tmp/tmp.u3nD3MuRDV", "start": "2025-02-19 10:01:18.090075", "end": "2025-02-19 10:01:18.166119"
Finished at 2025-02-19 10:01:18.166119

Switch logs:

2025 Feb 19 10:01:18.161836 r-tigon-20 NOTICE swss#swssconfig: :- main: Loading config from JSON file:/dev/stdin...
2025 Feb 19 10:01:18.437393 r-tigon-20 NOTICE syncd#SDK: [SAI_UTILS.NOTICE] ./src/mlnx_sai_utils.c[1969]- set_dispatch_attrib_handler: Set EGRESS_DISABLE, key:LAG_MEMBER [OID:0x100690000001B] [log_port:0x10069, lag_log_id:0x0], val:true
2025 Feb 19 10:01:18.439446 r-tigon-20 NOTICE swss#orchagent: :- setDistributionOnLagMember: Disable distribution on LAG member Ethernet0
2025 Feb 19 10:01:18.440116 r-tigon-20 NOTICE syncd#SDK: [SAI_UTILS.NOTICE] ./src/mlnx_sai_utils.c[1969]- set_dispatch_attrib_handler: Set INGRESS_DISABLE, key:LAG_MEMBER [OID:0x100690000001B] [log_port:0x10069, lag_log_id:0x0], val:true
2025 Feb 19 10:01:18.441281 r-tigon-20 NOTICE swss#orchagent: :- setCollectionOnLagMember: Disable collection on LAG member Ethernet0
2025 Feb 19 10:01:18.442631 r-tigon-20 NOTICE syncd#SDK: [SAI_UTILS.NOTICE] ./src/mlnx_sai_utils.c[1969]- set_dispatch_attrib_handler: Set EGRESS_DISABLE, key:LAG_MEMBER [OID:0x1006B0000001B] [log_port:0x1006B, lag_log_id:0x0], val:true
2025 Feb 19 10:01:18.444374 r-tigon-20 NOTICE swss#orchagent: :- setDistributionOnLagMember: Disable distribution on LAG member Ethernet4
2025 Feb 19 10:01:18.445108 r-tigon-20 NOTICE syncd#SDK: [SAI_UTILS.NOTICE] ./src/mlnx_sai_utils.c[1969]- set_dispatch_attrib_handler: Set INGRESS_DISABLE, key:LAG_MEMBER [OID:0x1006B0000001B] [log_port:0x1006B, lag_log_id:0x0], val:true
2025 Feb 19 10:01:18.446193 r-tigon-20 NOTICE swss#orchagent: :- setCollectionOnLagMember: Disable collection on LAG member Ethernet4

Actual configuration applied at 2025 Feb 19 10:01:18.446193

We should wait until the configuration applied, otherwise some traffic will still not be dropped causing test to fail

Test Plan

No response

Test environment

topo: t0-64

Attach files (if any)

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant