Remove cause of TypeError in get_tsa_tsb_service_uptime #14848
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes #14847
Remove unnecessary encode in
get_tsa_tsb_service_uptimefunction causing test failures due toTypeErrorintest_startup_tsa_tsb_service.py.Type of change
Back port request
Approach
What is the motivation for this PR?
To fix test failures in
test_startup_tsa_tsb_service.py.How did you do it?
Remove encode causing
TestErroringet_tsa_tsb_service_uptimefunction.How did you verify/test it?
Tested on T2 testbed that TypeError is no longer raised, and
get_tsa_tsb_service_uptimecontinues to function as intended.Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation
N/A