Change behaviour of wait and timeout assignment for T2 devices #14849
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes #14840
Changed behaviour of forcing minimum
wait
andtimeout
times for reboot on T2 devices to only trigger whensafe_reboot == True
Type of change
Back port request
Approach
What is the motivation for this PR?
Tests were failing when because of the minimum 900s wait time during reboot for T2 devices, despite explicitly setting wait time.
How did you do it?
Changed behaviour of forcing minimum
wait
andtimeout
times for reboot on T2 devices to only trigger whensafe_reboot == True
How did you verify/test it?
Tested on T2 testbed to confirm that the effective priority to define
wait
andtimeout
variables would now be:900, 600 for T2 DUT & safe reboot >
values defined in inv >
explicitly defined
wait
andtimeout
during function call >default values in
reboot_ctrl_dict
Any platform specific information?
Platform agnostic
Supported testbed topology if it's a new test case?
N/A
Documentation
N/A