-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run_vep_embeddings.py GPU memory allocation error #33
Comments
Hello, thank you for your interest and I'm sorry you are running into this issue. Some useful low-dimensional scores which should work out of the box:
Let me know if this makes sense and I'm happy to talk more about documented and undocumented ideas :) Regarding #27 I could certainly accept a pull request, thank you! |
Hi @gonzalobenegas. Thank you for your reply! I think I might have misunderstood the structure of the worked example provided at https://github.com/songlab-cal/gpn/tree/main/analysis/arabidopsis. I was applying the snakemake pipeline script to performance test my resources for a smaller genome like A. thaliana, and then was going to adapt it to some of the different taxa I work out to have a closer look at the results. I just wanted to make sure it worked all the way through before started to mess with individual steps. Given your response, would I be correct in thinking there's a different set of scripts or the ipython notebooks are needed to, say, adapt the analysis described in your 2023 PNAS paper to a different set of inputs? I'm interested in particular in both the validation of genome feature annotation and the variant effect prediction aspects of the manuscript. Sounds good about the pull request! Thanks again for your help. |
My bad. I see now that the Snakefile will run run_vep_embeddings by default as it is in the Some thoughts. If you just want to reproduce exactly the 2023 paper I would go back to the release labeled 0.2 and perhaps edit the rule However, I've done modifications to the training and inference code (updated code is in https://github.com/songlab-cal/gpn/blob/main/README.md), which I would recommend for new analysis. Some are related to performance, such as the use of torchrun and torch compile, and some are slight changes in argument names for consistency. You can still use the code in the Snakefile as a guide, but might need renaming e.g. Apologies again since my management of old analysis code and updated training scripts has been messy. |
Another note, if you just want to run the jupyter notebooks you can download all the intermediate files from Intermediate files necessary for running notebooks, such as embeddings and variant scores. |
@gonzalobenegas Thank you for the clarification, that is very helpful. I'll pull the 0.2 release and start working through things. I will go ahead and close this issue. I do have a few questions regarding applying the human model to mouse variants, and also the use of pangenomes as a training inputs. Would it be possible to email you directly with these questions? |
Sounds good, feel free to email me at [email protected]! |
Hi,
I've been trying to run through the Arabidopsis example as a test run in order to understand the pipeline prior to trying it out on my own system. However, I've run into a few errors that I was hoping to run by you.
The error I'm currently stuck on is resulting in the following message:
This error seems a bit strange given the large jump in memory allocation. I've tried varying the batch size down but I keep getting the error at around 62% completion no matter the batch size specified. The suggested modifications in #13 seem to no longer exist in the relevant script but perhaps I've missed something? You can see the full conda environment here: yaml . Exporting
PYTORCH_CUDA_ALLOC_CONF=expandable_segments:True
also makes no difference. Before I dig in a bit more I was just wondering if the solution is more obvious to you already?I also ran into the issue described in #27 and created a fork for a fix there. It's pretty small so I'm not sure I should put in a pull request given you may want to keep a consistent structure in the repo.
Please let me know if any additional information would be helpful. Thank you for your time and assistance.
The text was updated successfully, but these errors were encountered: