Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan for BS4 (Bootstrap 4) #4651

Closed
binhle410 opened this issue Sep 14, 2017 · 12 comments
Closed

Plan for BS4 (Bootstrap 4) #4651

binhle410 opened this issue Sep 14, 2017 · 12 comments

Comments

@binhle410
Copy link

Do we have any plan for BS4 support, maybe in SonataAdminBundle 4.x ?

@OskarStark
Copy link
Member

Not yet

@jvasseur
Copy link
Contributor

This will probably depend a lot on AdminLTE support for Bootstrap 4.

@soullivaneuh
Copy link
Member

@jvasseur answer is right. We depend to AdminLTE, not Bootstrap 4.

BTW, bootstrap 4 is not stable while I'm writing this comment.

Please open an issue on the AdminLTE repository.

Regards.

@memboc
Copy link

memboc commented Jan 9, 2019

@soullivaneuh Bootstrap4 is stable now. Here issue in AdminLTE repository.
The dev version already available now.

@kunicmarko20
Copy link
Contributor

This is a lot of work and my guess some BC breaks, especially since it needs to be done for all sonata bundles that have templates.

@haivala
Copy link

haivala commented Dec 18, 2019

Have anyone even tried this
https://github.com/ColorlibHQ/AdminLTE/releases/tag/v3.0.1

@stale
Copy link

stale bot commented Feb 16, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Feb 16, 2020
@SonataCI SonataCI removed the wontfix label Feb 16, 2020
@osavchenko
Copy link
Contributor

This issue is almost the same as #5597, but no work here. I think we can close it.

@wbloszyk
Copy link
Member

I should finish it in this week. I am waiting for #5461, but adminlte 3 can be done first.

@osavchenko
Copy link
Contributor

Sorry, I thought that AdminLTE will be upgraded with bootstrap in one go and one PR

@wbloszyk
Copy link
Member

AdminLTE RP will upgrade AdminLTE 2(based on bootstrap 3) to 3(based on bootstrap 4) . Webpack RP will change assets managing.

@core23
Copy link
Member

core23 commented Apr 1, 2020

We rely heavily on Admin LTE and it's bootstrap version. So we can't do this without upgrading Admin LTE. Closing this in favor of #5597

@core23 core23 closed this as completed Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests