Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folders get created unnecessarily for generated WebPs #4

Open
vibin opened this issue Jul 10, 2013 · 5 comments
Open

Folders get created unnecessarily for generated WebPs #4

vibin opened this issue Jul 10, 2013 · 5 comments

Comments

@vibin
Copy link

vibin commented Jul 10, 2013

Here's the snippet from my Grunt.js

    dist:{
      files: [{
        expand: true, 
        cwd: 'src/img',
        src:['*.jpg'],
        dest:'src/img/',
        ext:'.jpg.webp'
        }],
    },
      options:{
        quality:85,
    },
  },

When ever I run grunt webp, folders with name as [filename].jpg.webp get created and the actual .webp files reside inside them.

I don't want this to happen. I want my actual webp files to have the name [filename].jpg.webp and no extra folders should be created (as the dest is already mentioned).

@somerandomdude
Copy link
Owner

I'll look into this. Thanks!

P.J.

On Jul 10, 2013, at 12:34 AM, Vibin reddy [email protected] wrote:

Here's the snippet from my Grunt.js

dist:{
  files: [{
    expand: true, 
    cwd: 'src/img',
    src:['*.jpg'],
    dest:'src/img/',
    ext:'.jpg.webp'
    }],
},
  options:{
    quality:85,
},

},
When ever I run grunt webp, folders with name as [filename].jpg.webp get created and the actual .webp files reside inside them.

I don't want this to happen. I want my actual webp files to have the name [filename].jpg.webp and no extra folders should be created (as the dest is already mentioned).


Reply to this email directly or view it on GitHub.

@vibin
Copy link
Author

vibin commented Jul 15, 2013

Any progress?

I can see that this line in the webp.js file is creating folders. But I'm a beginner at Javascript stuff, so not really sure.

grunt.file.mkdir(dest);

@somerandomdude
Copy link
Owner

Not yet. It's on my list of things to do, but I haven't had time to look at it yet.
P.J.

On Mon, Jul 15, 2013 at 7:39 AM, Vibin reddy [email protected]
wrote:

Any progress?
I can see that this line in the webp.js file is creating folders. But I'm a beginner at Javascript stuff, so not really sure.

grunt.file.mkdir(dest);

Reply to this email directly or view it on GitHub:
#4 (comment)

@wiktor-k
Copy link

wiktor-k commented Dec 4, 2013

As far as I can see the bug exists in version 0.0.1 but is fixed in 0.0.2. The problem is 0.0.2 is not in npm repository so people by default download the buggy 0.0.1 release.

@TonySpegel
Copy link

As far as I can tell I have version "grunt-webp": "0.0.4" and it still creates unnecessary folders:

src: '_source_images/*.jpg',
dest: 'webp_images/'

creates _source_images IN webp_images wich in fact i don't want it to do.

Also that's over a year old... and still not fixed? ok..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants