-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simple cache #51
Merged
Merged
Add simple cache #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to test the cache implementation
…he' directory instead of downloading the plugins again and again
sd-lueckel
requested review from
michz,
mattagohni,
twojtylak,
Jnoack331,
TheBreaken and
sd-obermeyer
August 27, 2019 11:50
Jnoack331
previously approved these changes
Aug 27, 2019
twojtylak
reviewed
Aug 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about an option flag to ignore the cache within the command?
I think, that is a good idea |
…viour if a plugin should be loaded from the cache
… behaviour if a plugin should be loading from the cache
…aviour of loading a plugin from cache
…iour from the commandline
Now, the behaviour can be managed via a force parameter |
mattagohni
approved these changes
Aug 27, 2019
twojtylak
approved these changes
Aug 27, 2019
Jnoack331
approved these changes
Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little step to be able to fix #39