-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rendering of "Solr Plugin (JAR)" type installation comes up as "compile your own" #36
Comments
So, I thought that this might just be a simple change on the component.html file:
But it turns out that the I can imagine a different message than Compile your own, or we just don't list it. THere are plenty of projects that cut releases so you don't have to Compile your own, just not sure how best to communicate that! |
The more I think about it, and after reading https://github.com/solr-cool/solr-cool.github.io/blob/master/CONTRIBUTING.md#3-edit-package-descriptor, I'm wondering if we should just get rid of the Does it really matter how you install something if it ISN'T a Solr Package? Maybe we should say, if you have a This then makes those projects that A) cut a release, B) Have a solr package manager install, pop out a bit more! Eric |
Okay, learned something new... For the packages that are Solr packages, the JSON is properly rendered as:
But for the rest, there is no wrapping See https://github.com/solr-cool/solr-cool.github.io/blob/master/_data/releases/thymeleaf.json#L2 for a good example, and https://github.com/solr-cool/solr-cool.github.io/blob/master/_data/releases/payload-component.json#L1 for a missing I think if you regenerated those files, then PR #37 would work! |
The text was updated successfully, but these errors were encountered: