Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering of "Solr Plugin (JAR)" type installation comes up as "compile your own" #36

Open
epugh opened this issue Nov 13, 2020 · 3 comments

Comments

@epugh
Copy link
Contributor

epugh commented Nov 13, 2020

Screenshot at Nov 13 07-36-46

@epugh
Copy link
Contributor Author

epugh commented Nov 13, 2020

So, I thought that this might just be a simple change on the component.html file:

+                       {% if releases.solr_package %}
                        <li class="text-success"><i class="fa-li fa fa-cloud-download"></i>Package Manager Installation</li>
                        {% elsif releases.releases[0] %}
                        <li class="text-info"><i class="fa-li fa fa-floppy-o"></i>Manual installation (JAR)</li>
-                       {% else %}              
+                       {% elsif details.installation %}
+      <li class="text-info"><i class="fa-li fa fa-floppy-o"></i>{{ details.installation }}</li>
+      {% else %}

But it turns out that the installation key in the packages/ dir isn't copied over, maybe because once we moved to using Github, this is not actually a deprecated field?

I can imagine a different message than Compile your own, or we just don't list it. THere are plenty of projects that cut releases so you don't have to Compile your own, just not sure how best to communicate that!

@epugh
Copy link
Contributor Author

epugh commented Nov 13, 2020

The more I think about it, and after reading https://github.com/solr-cool/solr-cool.github.io/blob/master/CONTRIBUTING.md#3-edit-package-descriptor, I'm wondering if we should just get rid of the installation key...

Does it really matter how you install something if it ISN'T a Solr Package?

Maybe we should say, if you have a releases.releases[0] value then the message should just be Manual installation, and remove the (JAR) since it might very well be soemthing else.

This then makes those projects that A) cut a release, B) Have a solr package manager install, pop out a bit more!

Eric

@epugh
Copy link
Contributor Author

epugh commented Nov 13, 2020

Okay, learned something new... For the packages that are Solr packages, the JSON is properly rendered as:

{
  "releases": [
    {
      "name": "1.2.0", 
     }
  ]
}

But for the rest, there is no wrapping releases array.

See https://github.com/solr-cool/solr-cool.github.io/blob/master/_data/releases/thymeleaf.json#L2 for a good example, and https://github.com/solr-cool/solr-cool.github.io/blob/master/_data/releases/payload-component.json#L1 for a missing releases example.

I think if you regenerated those files, then PR #37 would work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant