Skip to content

Commit bfdb4a6

Browse files
bartnijssenJoe Hamman
authored and
Joe Hamman
committed
Fix/issue673 (UW-Hydro#742)
* Added release not for fixing UW-Hydro#673 * Renamed fcov to fcan per UW-Hydro#673 * Fixed releasenotes in response to review by jhamman
1 parent 3fd4800 commit bfdb4a6

File tree

2 files changed

+13
-7
lines changed

2 files changed

+13
-7
lines changed

docs/Development/ReleaseNotes.md

+11-5
Original file line numberDiff line numberDiff line change
@@ -68,16 +68,16 @@ To check which release of VIC you are running:
6868
Updates the cesm_put_data.c routine in the CESM driver to include the correct units for evap passed to the coupler.
6969

7070
[GH#732] (https://github.com/UW-Hydro/VIC/pull/732)
71-
72-
Updates the cesm_put_data.c routine in the CESM driver to include the correct units for sensible heat flux and updates the rofliq calculation to be correct (previously only OUT_BASEFLOW was being divided by global_param.dt).
7371

74-
[GH#734] (https://github.com/UW-Hydro/VIC/pull/734)
72+
Updates the cesm_put_data.c routine in the CESM driver to include the correct units for sensible heat flux and updates the rofliq calculation to be correct (previously only OUT_BASEFLOW was being divided by global_param.dt).
7573

76-
Updates the cesm_put_data.c routine in the CESM driver to include the correct signs for turbulent heat fluxes and evaporation. Previously we had switched the signs to agree with the image driver and they should instead be in accordance with the sign conventions for coupled models, which differ from those of land surface models. Also, eliminate populating the `l2x_Sl_ram1` field with aero_resist to agree with the VIC 4 implementation in RASM.
74+
[GH#734] (https://github.com/UW-Hydro/VIC/pull/734)
75+
76+
Updates the cesm_put_data.c routine in the CESM driver to include the correct signs for turbulent heat fluxes and evaporation. Previously we had switched the signs to agree with the image driver and they should instead be in accordance with the sign conventions for coupled models, which differ from those of land surface models. Also, eliminate populating the `l2x_Sl_ram1` field with aero_resist to agree with the VIC 4 implementation in RASM.
7777

7878
[GH#739] (https://github.com/UW-Hydro/VIC/pull/739)
7979

80-
Updates the cesm_put_data.c routine in the CESM driver to include the correct signs for the wind stresses and fixes a bug in calculating friction velocity (previously it was missing a square root).
80+
Updates the cesm_put_data.c routine in the CESM driver to include the correct signs for the wind stresses and fixes a bug in calculating friction velocity (previously it was missing a square root).
8181

8282
3. Speed up NetCDF operations in the image/CESM drivers ([GH#684](https://github.com/UW-Hydro/VIC/pull/684))
8383

@@ -99,6 +99,12 @@ To check which release of VIC you are running:
9999

100100
The VIC image and CESM drivers now may be optionally compiled with OPENMP to enable shared memory thread parallelization. This option should improve the parallel scaling of these drivers by reducing the number of MPI messages and increasing message size.
101101

102+
#### Bug Fixes:
103+
104+
1. Renamed "fcov" to "fcan" in image driver to better match variable code name ([GH#673](https://github.com/UW-Hydro/VIC/pull/673))
105+
106+
------------------------------
107+
102108
## VIC 5.0.1
103109

104110
**Release date: (February 1, 2017)**

vic/drivers/image/src/vic_force.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -335,14 +335,14 @@ vic_force(void)
335335
}
336336
}
337337

338-
// Partial veg cover fraction: fcov
338+
// Partial veg cover fraction: fcan
339339
if (options.FCAN_SRC == FROM_VEGHIST) {
340340
for (j = 0; j < NF; j++) {
341341
d4start[0] = global_param.forceskip[1] +
342342
global_param.forceoffset[1] + j;
343343
for (v = 0; v < options.NVEGTYPES; v++) {
344344
d4start[1] = v;
345-
get_scatter_nc_field_double(&(filenames.forcing[1]), "fcov",
345+
get_scatter_nc_field_double(&(filenames.forcing[1]), "fcan",
346346
d4start, d4count, dvar);
347347
for (i = 0; i < local_domain.ncells_active; i++) {
348348
vidx = veg_con_map[i].vidx[v];

0 commit comments

Comments
 (0)