Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConsistOfProtos matcher returns true if input is not a slice #445

Open
arianaw66 opened this issue Sep 9, 2021 · 0 comments
Open

ConsistOfProtos matcher returns true if input is not a slice #445

arianaw66 opened this issue Sep 9, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@arianaw66
Copy link
Contributor

Match implementation: https://github.com/solo-io/solo-kit/blob/v0.21.0/test/matchers/proto.go#L147

Uses result from:

solo-kit/test/matchers/proto.go

Line 198 in d7292e8

return result, true
, which perhaps should return result, false?
@arianaw66 arianaw66 added the bug Something isn't working label Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arianaw66