Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog utils CompareCommits call only fetches 300 files #492

Open
jbohanon opened this issue Jul 28, 2022 · 0 comments
Open

Changelog utils CompareCommits call only fetches 300 files #492

jbohanon opened this issue Jul 28, 2022 · 0 comments

Comments

@jbohanon
Copy link
Contributor

This can cause the changelog-bot to fail to find a valid changelog if there are >300 modifications that are alphanumerically prior to the location of the changelog file. This is in practice very unlikely to occur, but I have run into it while trying to restructure the changelog directories to put old versions' changelogs into minor-version subdirectories instead of patch-version subdirectories. This entailed moving >750 changelog files, all of which are alphanumerically prior to the changelog for the current PR.

I verified the 300 number by making the curl request against the API with

curl https://api.github.com/repos/solo-io/solo-projects/compare/v1.8.x...backports%2Fv1.8.x%2Fwaf-audit-logs-json -H "Accept: application/vnd.github+json" -H "Authorization: token <token with permission to view the repo>" -o ~/ghoutput
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant