Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if the intents_controller should live in the extension or among templates #247

Open
elia opened this issue Mar 22, 2023 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@elia
Copy link
Member

elia commented Mar 22, 2023

Why?

The controller is really simple and using well defined extension APIs. Everything else might be heavily dependent on the specific store setup (e.g. single page checkout, Ajax endpoints, etc.). So we might want to make it easy to adapt it to the store's needs.

What

Move it from app/controllers to lib/generator/…/templates.

@elia elia added the enhancement New feature or request label Mar 22, 2023
@elia elia added this to the v5 milestone Mar 22, 2023
@elia elia modified the milestones: v5, v5.1 Apr 27, 2023
@elia
Copy link
Member Author

elia commented Apr 27, 2023

Deferring to the next minor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant