Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate login/sign up/password recover pages #92

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Translate login/sign up/password recover pages #92

wants to merge 3 commits into from

Conversation

alepore
Copy link
Contributor

@alepore alepore commented May 23, 2017 •
edited
Loading

The SolidusI18n::ControllerLocaleHelper module is required to translate pages.
This is included on Spree::BaseController but not on the solidus_auth_devise controllers.

This PR adds the module to the missing controllers.

Closes #10

@alepore alepore requested a review from tvdeyen May 23, 2017 10:40
tvdeyen
tvdeyen approved these changes May 23, 2017
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! (besides the weird Bundler issues in the CI builds)

@alepore alepore force-pushed the login_translations branch 2 times, most recently from 19055a8 to de3a7b1 Compare May 24, 2017 08:25
@alepore alepore requested a review from jhawthorn May 24, 2017 08:35
@tvdeyen
Copy link
Member

tvdeyen commented Jun 2, 2017

🚢

@tvdeyen
Copy link
Member

tvdeyen commented Feb 7, 2018

@alepore could you please rebase

@tvdeyen tvdeyen added this to the 2.0 milestone Feb 7, 2018
@alepore alepore force-pushed the login_translations branch from de3a7b1 to f692dbb Compare February 9, 2018 07:39
@kennyadsl
Copy link
Member

@alepore sorry, can you rebase again (last time)? I’m going to merge as soon as specs pass. Thanks!

@alepore alepore force-pushed the login_translations branch from f692dbb to e182519 Compare March 15, 2018 19:43
@alepore
Copy link
Contributor Author

alepore commented Mar 22, 2018

😭

alepore added 3 commits March 27, 2018 21:48
@alepore
Add ControllerLocaleHelper to devise controllers
2434500 
Now login/sign up/password recover pages form solidus_auth_devise are
translated.
@alepore
Update spec to use the store preference
546904d
@alepore
Remove solidus_auth_devise version lock
7df24ef 
v2.x is required for Solidus 2.5+
@alepore alepore force-pushed the login_translations branch from 750eb90 to 7df24ef Compare March 27, 2018 20:05
@alepore
Copy link
Contributor Author

alepore commented Mar 27, 2018

image

@jhawthorn jhawthorn removed their request for review May 17, 2018 22:01
@stale
Copy link

stale bot commented Nov 11, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 11, 2022
@gsmendoza gsmendoza removed the wontfix label Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvdeyen tvdeyen tvdeyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

Login page does not accept locales (Version 1.1.1)
4 participants
@alepore @tvdeyen @kennyadsl @gsmendoza