Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support New Beta Version of Affirm with Secondary Financing Options #62

Closed
wants to merge 6 commits into from
Closed

Support New Beta Version of Affirm with Secondary Financing Options #62

wants to merge 6 commits into from

Conversation

peterberkenbosch
Copy link
Collaborator

@peterberkenbosch peterberkenbosch commented Apr 16, 2020 •
edited
Loading

This PR updates the integration with Affirm and uses the new Transaction API to support secondary financing options.

  • replace outdated gem with new affirm-ruby-api gem
  • remove VCR cassettes
  • add configuration for enable the secondary option through Affirm.
  • store payment provider with Affirm payment_source_class (SolidusAffirm::Checkout)
  • add tests for Solidus side of the implementation using the testing and stub support from affirm-ruby-api
  • add leasable field to Variants
  • refactor gateway to move the Affirm client calls into the SolidusAffirm wrapper
  • add callback hook for tax handler when secondary financing option is selected. This is a Lease to own option and is taking over the tax as well.
  • add default base tax handler hook that removes taxes.

Fixes #49

@peterberkenbosch
[wip] enable leasable products and merchant
da7ec57
@peterberkenbosch
follow along with the documentation and use open here
02af0a0
@peterberkenbosch
refactor first pass use affirm-ruby-api
74b7432 
Remove VCR in preparation in using the testing support
provided with affirm-ruby-api so can just focus on testing
the solidus behaviour and not also test the affirm api calls
since this is already done in the affirm-ruby-api gem.
@peterberkenbosch peterberkenbosch self-assigned this Apr 16, 2020
@peterberkenbosch
Copy link
Collaborator Author

closing this for now as per request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@peterberkenbosch peterberkenbosch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support New Beta Version of Affirm with Secondary Financing Options
1 participant
@peterberkenbosch