You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm trying to use this package together with styled-system. It seems to be working well so far, but the props are forwarded to the resulting HTML element, resulting in invalid attributes. For example, code like this:
<GridgridGap={[1,2]}m={3}>
...
</Grid>
generates HTML like this:
<divgridgap="1,2" m="2">
...
</div>
goober has shouldForwardProp that handles this. I think it would be neat if solid-styled-components could support this as well.
Proposal
Augment the existing setup function to add an optional argument for the shouldForwardProp predicate.
I'd be happy to open a PR if this sounds like something you'd like to merge.
The text was updated successfully, but these errors were encountered:
Yeah if have a good way of doing this I'm definitely open to the PR. Goober has been adding more features and I haven't been keeping on top of it I'm afraid. So help is much appreciated. Thank you.
Issue
I'm trying to use this package together with
styled-system
. It seems to be working well so far, but the props are forwarded to the resulting HTML element, resulting in invalid attributes. For example, code like this:generates HTML like this:
goober
hasshouldForwardProp
that handles this. I think it would be neat ifsolid-styled-components
could support this as well.Proposal
Augment the existing
setup
function to add an optional argument for theshouldForwardProp
predicate.I'd be happy to open a PR if this sounds like something you'd like to merge.
The text was updated successfully, but these errors were encountered: