Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support goober's shouldForwardProp #17

Closed
Asha20 opened this issue Feb 15, 2022 · 1 comment · Fixed by #22
Closed

Support goober's shouldForwardProp #17

Asha20 opened this issue Feb 15, 2022 · 1 comment · Fixed by #22

Comments

@Asha20
Copy link
Contributor

Asha20 commented Feb 15, 2022

Issue

I'm trying to use this package together with styled-system. It seems to be working well so far, but the props are forwarded to the resulting HTML element, resulting in invalid attributes. For example, code like this:

<Grid gridGap={[1, 2]} m={3}>
  ...
</Grid>

generates HTML like this:

<div gridgap="1,2" m="2">
  ...
</div>

goober has shouldForwardProp that handles this. I think it would be neat if solid-styled-components could support this as well.

Proposal

Augment the existing setup function to add an optional argument for the shouldForwardProp predicate.


I'd be happy to open a PR if this sounds like something you'd like to merge.

@ryansolid
Copy link
Member

Yeah if have a good way of doing this I'm definitely open to the PR. Goober has been adding more features and I haven't been keeping on top of it I'm afraid. So help is much appreciated. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants